Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show shards gives empty expiry time for inf duration shards #21795

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix: show shards gives empty expiry time for inf duration shards #21795

merged 1 commit into from
Jul 6, 2021

Conversation

lesam
Copy link
Contributor

@lesam lesam commented Jul 6, 2021 •
edited
Loading

Closes #21794

@lesam lesam force-pushed the fix-show-shards branch from 3172cab to dd42899 Compare July 6, 2021 14:54
@lesam lesam requested a review from gwossum July 6, 2021 14:54
@lesam lesam force-pushed the fix-show-shards branch from dd42899 to 5b54a66 Compare July 6, 2021 15:09
@lesam lesam force-pushed the fix-show-shards branch from 5b54a66 to 8ad988e Compare July 6, 2021 15:10
gwossum
gwossum approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what it says, like the new test case

@lesam lesam merged commit 8fa4d82 into influxdata:master-1.x Jul 6, 2021
@lesam lesam mentioned this pull request Jul 8, 2021
Closed
7 tasks
lesam added a commit to lesam/influxdb that referenced this pull request Jul 8, 2021
@lesam
fix: show shards gives empty expiry time for inf duration shards (inf…
6d5a890 
…luxdata#21795)

(cherry picked from commit 8fa4d82)
lesam added a commit that referenced this pull request Jul 8, 2021
@lesam
fix: show shards gives empty expiry time for inf duration shards (#21795
1aaaee3 
) (#21807)

(cherry picked from commit 8fa4d82)
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 11, 2024
@lesam @chengshiwen
fix: show shards gives empty expiry time for inf duration shards (inf…
e7c8729 
…luxdata#21795)
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
@lesam @chengshiwen
fix: show shards gives empty expiry time for inf duration shards (inf…
6b0f5de 
…luxdata#21795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwossum gwossum gwossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesam @gwossum