Broker log recovery #2167
Merged
Broker log recovery #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1017,6 +1009,19 @@ func NewTopicReader(path string, index uint64, streaming bool) *TopicReader { | |||
| } | |||
| } | |||
|
|
|||
| // Seek seeks to a position the current segment. | |||
| func (r *TopicReader) Seek(offset int64, whence int) (int64, error) { | |||
| assert(whence == os.SEEK_CUR, "topic reader can only seek to a relative position") | |||
There was a problem hiding this comment.
Seems like you could remove this assert by simply having this function ignore whence, and then calling Seek() with os.SEEK_CUR. Of course, you may wish to catch errors in the future.
There was a problem hiding this comment.
If someone passes a non-SEEK_CUR in the future I want to catch it immediately. If I silently override it then it'll be a pain to debug.
|
+1, change looks good to me. I do have some questions about the Don't forget the CHANGELOG. |
|
👍 |
This pull request adds recovery to the messaging.Topic when opening. If any partial messages are found then the file is truncated at that point and started from there. This can occur when ungracefully shutting down a server. It can leave half written messages at the end of segments.
benbjohnson
force-pushed
the
broker-recovery
branch
from
fabc4b4 to
ba3026f
Compare
…oker-recovery Conflicts: CHANGELOG.md
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 9, 2019
Mock implementation of various services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds recovery to the messaging.Topic when opening. If any partial messages are found then the file is truncated at that point and started from there. This can occur when ungracefully shutting down a server. It can leave half written messages at the end of segments.