Don't panic if presented with a field of unknown type #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
dont_panic_on_missing_field_mapping
branch
from
6020ebb to
9a2ac21
Compare
| // mapping for the data during decode. All this can happen because data is encoded by the node | ||
| // that first received the write request, not the node that actually writes the data to disk. | ||
| // So if this happens, skip the data. | ||
| continue |
There was a problem hiding this comment.
Actually, I need to push the reader ahead -- let me fix this.
|
LGTM |
otoolep
force-pushed
the
dont_panic_on_missing_field_mapping
branch
from
9a2ac21 to
af0d59b
Compare
|
👍 |
|
@otoolep needs a rebase. Will merge on green |
|
👍 |
This can happen, though is very unlikely. If this node receives encoded data, to be written to disk, and is queried for that data before its metastore is updated, there will be no field mapping for the data during decode. All this can happen because data is encoded by the node that first received the write request, not the node that actually writes the data to disk. So if this happens, skip the data.
otoolep
force-pushed
the
dont_panic_on_missing_field_mapping
branch
from
af0d59b to
501b4ce
Compare
otoolep
added a commit
that referenced
this pull request
Apr 4, 2015
…pping Don't panic if presented with a field of unknown type
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
chore(http): remove debug printf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen, though is very unlikely. If this node receives encoded
data, to be written to disk, and is queried for that data before its
metastore is updated, there will be no field mapping for the data during
decode. All this can happen because data is encoded by the node that first
received the write request, not the node that actually writes the data to
disk. So if this happens, skip the data.