Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init script to append STDERR to log. #2164

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Conversation

benbjohnson
Copy link
Contributor

Overview

This pull request changes init.sh to append standard error to the existing log, if one exists.

@benbjohnson
Copy link
Contributor Author

@otoolep

@otoolep
Copy link
Contributor

otoolep commented Apr 3, 2015

Shouldn't we do the same for STDOUT? It, too, could be a file.

@otoolep
Copy link
Contributor

otoolep commented Apr 3, 2015

Update the CHANGELOG. Once you answer (and possibly address) the question about STDOUT +1.

@benbjohnson
Copy link
Contributor Author

I wasn't sure what would happen if I tried to append to /dev/null so I figured I'd just do STDERR for now. I should have just tried it out. It's fine. I added it & updated the CHANGELOG.

@@ -9,6 +9,7 @@
- [#2151](https://github.com/influxdb/influxdb/pull/2151): Ignore replay commands on the metastore.
- [#2156](https://github.com/influxdb/influxdb/pull/2156): Propagate error when resolving UDP address in Graphite UDP server.
- [#2163](https://github.com/influxdb/influxdb/pull/2163): Fix up paths for default data and run storage.
- [#2164](https://github.com/influxdb/influxdb/pull/2164): Append STDOUT/STDERR in initscript.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit-pick: typo? initscript -> init script

benbjohnson added a commit that referenced this pull request Apr 3, 2015
Update init script to append STDERR to log.
@benbjohnson benbjohnson merged commit 93be4b0 into master Apr 3, 2015
@benbjohnson benbjohnson deleted the append-log branch April 3, 2015 20:38
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
fix(write): fix close logic to avoid race from read error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants