Set Go Max procs in a better location #2147
Conversation
| @@ -78,11 +74,13 @@ func main() { | |||
| case "": | |||
| execRun(args) | |||
| case "backup": | |||
| setGoMaxProcs() | |||
There was a problem hiding this comment.
Do backup and restore really benefit from this?
There was a problem hiding this comment.
That's a good question for @benbjohnson. Not sure if more procs helps out with any of the system packages we depend on.
There was a problem hiding this comment.
Minor: why do it in the switch statement for some cases, but then do it explicitly in execRun for that case?
There was a problem hiding this comment.
I don't think it's necessary. Backup & restore is single threaded since it builds a tar archive sequentially.
There was a problem hiding this comment.
@otoolep looks like we can remove it from everywhere but run. However, the reason I didn't put it in the switch statement for the run is it printed above the logo, and felt out of place. I'll just leave that in the run and remove all of them from the switch, as well as the actual function now that we are clear on the use case.
|
I think I would just push the call into |
…nfluxdb into set-max-procs-better-location
Set Go Max procs in a better location
fix(http): rename piging_test to paging_test
Go max procs doesn't always need to be set. It doesn't really hurt anything, but the log statement had an undesired side affect.