Support chunked responses #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
chunked-responses-2
branch
from
cfff34f to
91a3a77
Compare
Refactored query engine to have different processing pipeline for raw queries. This enables queries that have a large offset to not keep everything in memory. It also makes it so that queries against raw data that have a limit will only p rocess up to that limit and then bail out. Raw data queries will only read up to a certain point in the map phase before yielding to the engine for further processing. Fixes #2029 and fixes #2030
otoolep
force-pushed
the
chunked-responses-2
branch
from
91a3a77 to
21cc80a
Compare
|
@corylanou -- this is basically the same as before, and I am copying @benbjohnson since he was copied previously. |
otoolep
force-pushed
the
chunked-responses-2
branch
3 times, most recently
from
a1e0a7b to
42ee6f4
Compare
|
OK, there is 1 final failure here -- I need to deal with chunking correctly. I've fixed the incorrect splitting into separate rows, but the fix is not quite right. |
otoolep
force-pushed
the
chunked-responses-2
branch
from
42ee6f4 to
bc3bef6
Compare
otoolep
force-pushed
the
chunked-responses-2
branch
from
bc3bef6 to
41c59dd
Compare
|
Looks good, what's the last thing? |
|
Didn't quite get chunking right. Kicked the build again, because of a known race in the Raft code (which I need to look into). |
|
I will merge on a green build. |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
fix(http): replace default-404 handler with custom-404 handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.