chore(ae): add more logging #21381
Merged
chore(ae): add more logging #21381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsdb.Engine.IsIdle and tsdb.Shard.Digest now take a boolean parameter, isLogged. If this is true, the engine will use trace-logging and report which checks are causing the engine not to be idle. tsdb.Shard exposes a funcion LoggedIsIdle() which calls tsdb.Engine.IsIdle(true). This is only used in calls from the anti-entropy service in Enterprise.
danxmoran
reviewed
May 5, 2021
dgnorton
reviewed
May 5, 2021
davidby-influx
force-pushed
the
DSB_ae_logging
branch
from
246c08f to
33aecc5
Compare
dgnorton
reviewed
May 7, 2021
Co-authored-by: David Norton <dgnorton@gmail.com>
davidby-influx
force-pushed
the
DSB_ae_logging
branch
from
cc09142 to
2570fe7
Compare
danxmoran
previously approved these changes
May 7, 2021
tsdb/shard.go
Outdated
| } | ||
|
|
||
| // Make sure the shard is idle/cold. (No use creating a digest of a | ||
| // hot shard that is rapidly changing.) | ||
| if !engine.IsIdle() { | ||
| return nil, 0, ErrShardNotIdle | ||
| if state, reason := engine.IsIdle(); !state { |
There was a problem hiding this comment.
Suggested change
| if state, reason := engine.IsIdle(); !state { | |
| if isIdle, reason := engine.IsIdle(); !isIdle { |
Easier for me to understand, the current way took my brain a bit to process
danxmoran
approved these changes
May 7, 2021
davidby-influx
added a commit
that referenced
this pull request
May 10, 2021
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle. Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the caller may want to add the shard ID and path for more information in the log. This is intended to be used in calls from the anti-entropy service in Enterprise. (cherry picked from commit bf45841)
davidby-influx
added a commit
that referenced
this pull request
May 11, 2021
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle. Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the caller may want to add the shard ID and path for more information in the log. This is intended to be used in calls from the anti-entropy service in Enterprise. (cherry picked from commit bf45841) fixes #21448
davidby-influx
added a commit
that referenced
this pull request
May 17, 2021
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle. Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the caller may want to add the shard ID and path for more information in the log. This is intended to be used in calls from the anti-entropy service in Enterprise. (cherry picked from commit bf45841) Fixes #21449
davidby-influx
added a commit
that referenced
this pull request
May 17, 2021
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle. Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the caller may want to add the shard ID and path for more information in the log. This is intended to be used in calls from the anti-entropy service in Enterprise. (cherry picked from commit bf45841) Fixes #21449
davidby-influx
added a commit
that referenced
this pull request
Jul 20, 2021
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle. Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the caller may want to add the shard ID and path for more information in the log. This is intended to be used in calls from the anti-entropy service in Enterprise. (cherry picked from commit bf45841) fixes #21448 (cherry picked from commit c8da9ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsdb.Engine.IsIdle and tsdb.Engine.Digest now return a reason string for why the engine & shard are not idle.
Callers can then use this string for logging, if desired. The returned reason does not allocate memory, so the
caller may want to add the shard ID and path for more information in the log. This is intended to be used in
calls from the anti-entropy service in Enterprise.
Closes #21380