Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): cursor requests are [start, stop] instead of [start, stop) #21349

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

danxmoran
Copy link
Contributor

Backports #21318

Original description:

The cursors were previously [start, stop) to be consistent with how flux requests data, but the underlying storage file store was [start, stop] because that's how influxql read data. This reverts back the cursor behavior so that it is now [start, stop] everywhere and the conversion from [start, stop) to [start, stop] is performed when doing the cursor request to get the next cursor.

The cursors were previously [start, stop) to be consistent with how flux
requests data, but the underlying storage file store was [start, stop]
because that's how influxql read data. This reverts back the cursor
behavior so that it is now [start, stop] everywhere and the conversion
from [start, stop) to [start, stop] is performed when doing the cursor
request to get the next cursor.

Co-authored-by: Sam Arnold <sarnold@influxdata.com>
Copy link
Contributor

@lesam lesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport.

I prefer cherry-pick -x, but won't insist on it.

@danxmoran danxmoran merged commit 46e7ad3 into 2.0 Apr 30, 2021
@danxmoran danxmoran deleted the dm-backport-flux-range-fix branch April 30, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants