Set GOMAXPROCS. #2112
Merged
Set GOMAXPROCS. #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,9 @@ func main() { | |||
| commit = "unknown" | |||
| } | |||
|
|
|||
| // Set parallelism. | |||
| runtime.GOMAXPROCS(runtime.NumCPU()) | |||
There was a problem hiding this comment.
I'd like to suggest we explicitly log this, so the user knows it's happening. E.g.
log.Println("GOMAXPROCS set to", runtime.GOMAXPROCS(0))
There was a problem hiding this comment.
good idea. I'm going to do that and merge this.
There was a problem hiding this comment.
OK, cool. Just be sure to add the log line after setting it. :-)
|
+1 on CHANGELOG update (and green build). |
|
❤️ |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 9, 2019
docs(http): remove unused org param from swagger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request simply sets
GOMAXPROCSbased on the number of available CPUs.