fix(tsm1): fix data race and validation in cache ring #20843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious if need to delete |
I'll investigate, and open a follow-up PR if so. In general I'd prefer to keep these backports as close to the original merges as possible, otherwise we need to track forward-ports in addition to backports and it all becomes a mess. EDIT: That method was indeed dead code, I've opened a PR to delete it. Once that merges I'll add the cherry-picked commit here. |
danxmoran
force-pushed
the
dm-backport-ring-fixes-20801
branch
2 times, most recently
from
b071afe to
27f9105
Compare
Co-authored-by: Yun Zhao <zhaoyun2316@gmail.com>
danxmoran
force-pushed
the
dm-backport-ring-fixes-20801
branch
from
27f9105 to
525aa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20801
Backports #20797, #20803, and #20890