Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing intervals for group by. #2067

Merged
merged 7 commits into from
Mar 25, 2015
Merged

Fixing intervals for group by. #2067

merged 7 commits into from
Mar 25, 2015

Conversation

corylanou
Copy link
Contributor

We previously accepted a PR that broke the interval buckets for group by.

Effectively, if you asked for a group by 10s, and started your time query on a 05 second interval, the buckets didn't calculate properly.

The issue though, was real, so we created the proper fix for this PR that we also reverted at the same time: #2016

Also fixes Issue #2045

@influxdb-denver-pair influxdb-denver-pair changed the title Fixing intervals for group by. Fixing bad PR Fixing intervals for group by. Mar 24, 2015
@@ -13,6 +13,7 @@
- [#2040](https://github.com/influxdb/influxdb/pull/2040): Add missing top-level help for config command.
- [#2057](https://github.com/influxdb/influxdb/pull/2057): Move racy "in order" test to integration test suite.
- [#2060](https://github.com/influxdb/influxdb/pull/2060): Reload server shard map on restart.
- [#2067](https://github.com/influxdb/influxdb/pull/2067): Fixing intervals for group by.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Capitalize GROUP BY for readability in the CHANGELOG.

@corylanou corylanou force-pushed the relative-times-off-2045 branch from d163ba8 to 84a9b8a Compare March 25, 2015 02:15
pauldix added a commit that referenced this pull request Mar 25, 2015
@pauldix pauldix merged commit 7076b9e into master Mar 25, 2015
@corylanou corylanou deleted the relative-times-off-2045 branch April 23, 2015 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants