Drop measurement was taking to long due to transactions #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1139,9 +1137,9 @@ func (db *database) dropMeasurement(name string) error { | |||
| } | |||
|
|
|||
| // dropSeries will delete all data with the seriesID | |||
| func (rp *RetentionPolicy) dropSeries(seriesID uint32) error { | |||
| func (rp *RetentionPolicy) dropSeries(seriesIDs ...uint32) error { | |||
There was a problem hiding this comment.
I'm curious about this style. More preferred/idiomatic than doing []uint32? Or is it because you want to be able to support just passing in one ID?
There was a problem hiding this comment.
So, idiomatic is becoming a 4 letter word in the go community, but yes, it is to support sending a single series ID in the future.
This way, your signature for drop series would be dropSeries(id) as opposed to dropSeries([]SeriesIDs{id}).
This is very common to see in the standard library as well.
There was a problem hiding this comment.
rad, I"ll have to remember it :)
|
As much as I would love to see tens of thousands of BoltDB transactions, this seems like a good idea to me. |
toddboom
added a commit
that referenced
this pull request
Mar 17, 2015
Drop measurement was taking to long due to transactions
|
LGTM |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
fix(http): convert scraper target error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you had 10k series, it was creating 10k bolt transactions, which of course, takes a lot of time. Now, it creates significantly less transactions (only as many as you have shards). I was seeing results of
DROP MEASUREMENTtaking a couple minutes, and now takes less than 20ms.