feat: flows index #19448
Merged
feat: flows index #19448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
force-pushed
the
feat/index-flows
branch
from
17799af
to
eb4a58b
Compare
drdelambre
reviewed
Aug 26, 2020
| @@ -108,17 +108,17 @@ export const generateNavItems = (orgID: string): NavItem[] => { | |||
| activeKeywords: ['data-explorer'], | |||
| }, | |||
| { | |||
| id: 'notebooks', | |||
| testID: 'nav-item-notebooks', | |||
| id: 'flows', | |||
drdelambre
reviewed
Aug 26, 2020
| {isFlagEnabled('notebooks') && ( | ||
| <Route path={`${orgPath}/notebooks`} component={NotebookPage} /> | ||
| <Route path={`${orgPath}/notebooks/:id`} component={NotebookPage} /> |
There was a problem hiding this comment.
can rename this if like!
drdelambre
reviewed
Aug 26, 2020
| return ( | ||
| <EmptyState size={ComponentSize.Large}> | ||
| <EmptyState.Text> | ||
| Looks like there aren't any <b>Flows</b>, why not create one? |
There was a problem hiding this comment.
should we just make one for them instead?
drdelambre
reviewed
Aug 26, 2020
| @@ -2,7 +2,7 @@ | |||
| import React, {FC, useContext, useCallback} from 'react' | |||
|
|
|||
| // Contexts | |||
| import {NotebookContext} from 'src/notebooks/context/notebook' | |||
| import {NotebookContext} from 'src/notebooks/context/notebook.current' | |||
There was a problem hiding this comment.
well this is embarassing
drdelambre
reviewed
Aug 26, 2020
| @@ -14,23 +14,27 @@ export interface PipeMeta { | |||
| // TODO: this is screaming for normalization. figure out frontend uuids for cells | |||
There was a problem hiding this comment.
I think we can delete this whole file? maybe later, but i got confused as to how any of this worked
drdelambre
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7151
Notes
This index is purposefully very, very ugly. It is not done. Not even close. But, you can now create and view multiple flows and differentiate them based on a meaningful name.