Cosmetic CLI output fixes #1908

corylanou · 2015-03-10T22:58:01Z

This fixes the following types of queries:

FROM:

> select * from cpu
name    tags    time                            value
----    ----    ----                            -----
cpu             2015-01-26T22:01:11.703Z        100
cpu             2015-01-27T22:01:11.703Z        100
cpu             2015-01-28T22:01:11.703Z        100

TO:

> select * from cpu
name    time                            value
----    ----                            -----
cpu     2015-01-26T22:01:11.703Z        100
cpu     2015-01-27T22:01:11.703Z        100
cpu     2015-01-28T22:01:11.703Z        100

FROM:

> show series
name    tags    id      host
----    ----    --      ----
cpu             1       server01
----    ----    --      ----
mem             2       server01

TO:

> show series
name    id      host
----    --      ----
cpu     1       server01
name    id      host
----    --      ----
mem     2       server01

FROM:

> show databases
name    tags    name
----    ----    ----
                foo

TO:

> show databases
name
----
foo

otoolep · 2015-03-10T23:00:42Z

In the first example, there are no more tags? And how does it look if there is more than 1 value? Can you show that?

corylanou · 2015-03-10T23:25:58Z

with tags:

> select * from temp group by *
name    tags                            time                            value
----    ----                            ----                            -----
temp    host=server01,region=useast     2015-02-27T22:01:11.703Z        101.1
name    tags                            time                            value
----    ----                            ----                            -----
temp    region=uswest,host=server01     2015-02-26T22:01:11.703Z        98.6
name    tags                            time                            value
----    ----                            ----                            -----
temp    host=server02,region=useast     2015-02-28T22:01:11.703Z        105.4

with multiple values:

> select * from network
name    time                            tx      rx
----    ----                            --      --
network 2015-02-26T22:01:11.703Z        9804    2342
network 2015-02-27T22:01:11.703Z        7930    4324
network 2015-02-28T22:01:11.703Z        8234    2342

otoolep · 2015-03-10T23:37:00Z

cmd/influx/main.go

 		}
+		// Output a line seperator if we have more than one set or results


Nit: 'separator' is misspelled. And should it be "...of results"?

otoolep · 2015-03-10T23:47:01Z

I like the output changes, though I have some minor feedback on the code. Once that is addressed, +1 from me.

corylanou · 2015-03-11T15:30:38Z

Ok, so based on feedback, I have made quite a few changes to the column format output. I left the csv format in tact if we need it for future (which I think makes sense as you would be able to use this in a non-interactive mode to get results).

Here are the new examples:

> show databases
name
foo

> show series
cpu
---
id
1

mem
---
id      host
2       server01
3       server02

network
-------
id      host            region
7       server01        uswest
8       server01        useast
9       server02        useast

temp
----
id      host            region
4       server01        uswest
5       server01        useast
6       server02        useast

> show measurements
measurements
------------
name
cpu
mem
network
temp
> select * from cpu
cpu
---
time                            value
2015-02-26T22:01:11.703Z        8.9
2015-02-27T22:01:11.703Z        1.3
2015-02-28T22:01:11.703Z        50.4

> select * from temp group by *
temp
----------------------------------
tags: host=server01, region=useast
----------------------------------
time                            value
----                            -----
2015-02-27T22:01:11.703Z        101.1

temp
----------------------------------
tags: host=server01, region=uswest
----------------------------------
time                            value
----                            -----
2015-02-26T22:01:11.703Z        98.6

temp
----------------------------------
tags: host=server02, region=useast
----------------------------------
time                            value
----                            -----
2015-02-28T22:01:11.703Z        105.4

cc @otoolep @pauldix

otoolep · 2015-03-11T16:51:44Z

Is this still open to feedback? Because I think the output from select * from temp group by * is still too hard to read. There are too much use of '-----', which means it's hard to quickly see what is grouped with what. My eyes keep being drawn to what is surrounded by --- so it looks like tags is the section title, not the measurement name. How about the simplified version below?

> select * from temp group by *
temp
tags: host=server01, region=useast
time                            value
----                            -----
2015-02-27T22:01:11.703Z        101.1

temp
tags: host=server01, region=uswest
time                            value
----                            -----
2015-02-26T22:01:11.703Z        98.6

temp
tags: host=server02, region=useast
time                            value
----                            -----
2015-02-28T22:01:11.703Z        105.4

otoolep · 2015-03-11T16:53:09Z

Or:

> select * from temp group by *
measurement: temp
tags: host=server01, region=useast
time                            value
----                            -----
2015-02-27T22:01:11.703Z        101.1

measurement: temp
tags: host=server01, region=uswest
time                            value
----                            -----
2015-02-26T22:01:11.703Z        98.6

measurement: temp
tags: host=server02, region=useast
time                            value
----                            -----
2015-02-28T22:01:11.703Z        105.4

This form has the advantage of helping our users understand the term 'measurement', as used within our system.

corylanou · 2015-03-11T17:04:40Z

That format was proposed by @pauldix . I'll let you guys come to consensus. FWIW, I think I like less lines per what @otoolep proposes.

As for

measurement: temp

I don't always now that row.Name is a measurement name, as sometimes it isn't.

otoolep · 2015-03-11T17:05:26Z

OK, if row.Name is not always a measurement, then scrap that idea.

corylanou · 2015-03-11T17:17:42Z

What if we did:

> select * from temp group by *
name: temp
tags: host=server01, region=useast
time                            value
----                            -----
2015-02-27T22:01:11.703Z        101.1


name: temp
tags: host=server01, region=uswest
time                            value
----                            -----
2015-02-26T22:01:11.703Z        98.6


name: temp
tags: host=server02, region=useast
time                            value
----                            -----
2015-02-28T22:01:11.703Z        105.4

And if we clean up some inconsistencies in responses for things that don't need names, like show databases or show measurements it will actually work out quite nicely.

otoolep · 2015-03-11T17:59:10Z

Can you show a couple more examples? How does stuff like count look?

corylanou · 2015-03-11T22:53:34Z

@otoolep latest outputs:

> show databases
name
foo

> show series
name: cpu
---------
id
1


name: mem
---------
id      host
2       server01
3       server02


name: network
-------------
id      host            region
7       server01        uswest
8       server01        useast
9       server02        useast


name: temp
----------
id      host            region
4       server01        uswest
5       server01        useast
6       server02        useast

> show measurements
name: measurements
------------------
name
cpu
mem
network
temp

> select * from temp group by *
name: temp
tags: host=server01, region=useast
time                            value
----                            -----
2015-02-27T22:01:11.703Z        101.1


name: temp
tags: host=server01, region=uswest
time                            value
----                            -----
2015-02-26T22:01:11.703Z        98.6


name: temp
tags: host=server02, region=useast
time                            value
----                            -----
2015-02-28T22:01:11.703Z        105.4

> select count(value) from cpu
name: cpu
---------
time                    count
1970-01-01T00:00:00Z    3

corylanou · 2015-03-12T16:47:54Z

I think we are as far as we are going to get on this for now. It fixes several output format bugs, and has improved greatly from what it was. We can come back later to tweak further at a future date.

toddboom · 2015-03-12T16:49:25Z

@corylanou rad, can you rebase and push? i'll merge it in.

toddboom · 2015-03-12T16:49:55Z

@corylanou nevermind. ;)

…erator -> separator

pauldix · 2015-03-12T18:36:44Z

@corylanou latest looks rad, 🚢 while it's hot!

Refs #1908

corylanou added the 2 - Working label Mar 10, 2015

otoolep reviewed Mar 10, 2015
View reviewed changes

corylanou self-assigned this Mar 11, 2015

corylanou added review and removed 2 - Working labels Mar 11, 2015

corylanou force-pushed the cli-output-fixes branch from b33ea14 to a97c4a3 Compare March 12, 2015 16:49

corylanou added 8 commits March 12, 2015 11:17

stop writing blank columns, repeate headers as necessary

96856ff

add shell script to input data with more variety

2e9d56f

fixing bug with headers output

b36217c

add line separator between result outputs

b94027f

no more line headers

891a156

refactoring column format to be much more intelligent, fixed typo sep…

f0f3be9

…erator -> separator

no need to pass arg

2480403

no need to pass arg

b18ac07

corylanou added 5 commits March 12, 2015 11:17

sort tags for consistency

04ed8a8

add trailing line separator for column format

15e1f9a

update changelog

00437b6

append line separator in correct spot

5ce7307

less header lines

b0be24b

corylanou force-pushed the cli-output-fixes branch from a97c4a3 to b0be24b Compare March 12, 2015 17:17

toddboom merged commit b0be24b into master Mar 12, 2015

toddboom removed the review label Mar 12, 2015

toddboom deleted the cli-output-fixes branch March 12, 2015 18:42

leodido added a commit that referenced this pull request Jan 10, 2019

feat(http): get macros via http accounts for query parameters

dc12549

Refs #1908

leodido added a commit that referenced this pull request Jan 15, 2019

feat(http): get macros via http accounts for query parameters

0ab1e67

Refs #1908

leodido added a commit that referenced this pull request Jan 15, 2019

feat(http): get macros via http accounts for query parameters

992207e

Refs #1908

leodido added a commit that referenced this pull request Jan 15, 2019

feat(http): get macros via http accounts for query parameters

0f3a076

Refs #1908

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cosmetic CLI output fixes #1908

Cosmetic CLI output fixes #1908

corylanou commented Mar 10, 2015

otoolep commented Mar 10, 2015

corylanou commented Mar 10, 2015

otoolep Mar 10, 2015

otoolep commented Mar 10, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

corylanou commented Mar 12, 2015

toddboom commented Mar 12, 2015

toddboom commented Mar 12, 2015

pauldix commented Mar 12, 2015

		}
		// Output a line seperator if we have more than one set or results

Cosmetic CLI output fixes #1908

Cosmetic CLI output fixes #1908

Conversation

corylanou commented Mar 10, 2015

otoolep commented Mar 10, 2015

corylanou commented Mar 10, 2015

otoolep Mar 10, 2015

Choose a reason for hiding this comment

otoolep commented Mar 10, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

otoolep commented Mar 11, 2015

corylanou commented Mar 11, 2015

corylanou commented Mar 12, 2015

toddboom commented Mar 12, 2015

toddboom commented Mar 12, 2015

pauldix commented Mar 12, 2015