-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show servers to query language #1906
Conversation
Yes, it should actually have an extra column that is something like "role" which has data, broker, or both
I guess it should just have whatever the connect URL is.
We should keep an in memory map of all heartbeat information. All brokers and data nodes should be heartbeating through raft on a regular basis. The data node heartbeats should include which shards they have and what the last written raft index is for each of those shards.
The index only has meaning on a per topic basis. I think we may want to expand this functionality to show the detailed information of each data node, which would include what topics it has, what raft index each one is at, and what it knows about the cluster (other data nodes, brokers, etc)
No, just maybe a
I think |
I think If this is not the case, we need clearer requirements for each of there commands, since there is overlap in how they are currently spec'ed out. See: #1470 |
@corylanou -- happy to work together on this, so we can come up with something consistent and comprehensive. |
@otoolep I agree, if we are doing show stats, then this should be a more simplistic response that gets you into a more in depth response. Does it make sense to merge this as is and let you pick it up on your branch with a rebase? Seems like the two issues are pretty closely related. |
Thanks @corylanou -- if you merge, I can develop further. +1 from me once the changelog is updated. |
Add show servers to query language
Currently lists only data nodes, with the id/url:
Questions:
where
clauses to show server?SHOW DATANODES
andSHOW BROKERS
vs.SHOW SERVERS
?Addresses #1469