Pre-create shard groups #1897
Pre-create shard groups #1897
Conversation
1) Pre create shard groups 2) Calculate and save the ShardGroupDuration for Retention Policies. This should never change even if they alter a retention policy in the future
| RetentionAutoCreate bool `toml:"retention-auto-create"` | ||
| RetentionCheckEnabled bool `toml:"retention-check-enabled"` | ||
| RetentionCheckPeriod Duration `toml:"retention-check-period"` | ||
| ShardGroupPreCreateCheckPeriod Duration `toml:"shard-group-pre-create-check-period"` |
There was a problem hiding this comment.
This is a pretty awkwardly-named config variable. :-) How about something as simple as retention-create-period?
There was a problem hiding this comment.
"Shard groups" is an implementation detail, one of the reasons I don't like seeing it in the key names.
|
"pre-create" is not the clearest term. How about "rolling create"? I think this might better get across that it starts with some existing shard groups, and then continue to "roll" them into the future. |
| } | ||
|
|
||
| // ShardGroupPreCreate ensures that future shard groups and shards are created and ready for writing | ||
| // is removed from the server. |
There was a problem hiding this comment.
This comment seems to have trailing text.
There was a problem hiding this comment.
Line 364 or 365? I can't seem to find it. Also /\s\+$ in Vim on that file shows nothing...
|
Agree that you don't need a different message type from creating a shard group vs. precreating. Either way the result is the same, you're creating a shard group for a given block of time. |
|
LGTM, 🚢 |
|
Nice. No more PreCreate messages. |
Pre create shard groups
Calculate and save the ShardGroupDuration for Retention Policies. This should never change even if they alter a retention policy in the future
Fixes #1873
Fixes #1783