Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLock Server when checking retention policies #1883

Merged
merged 2 commits into from
Mar 9, 2015
Merged

RLock Server when checking retention policies #1883

merged 2 commits into from
Mar 9, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Mar 8, 2015

No description provided.

@otoolep otoolep mentioned this pull request Mar 8, 2015
Closed
@otoolep
Copy link
Contributor Author

otoolep commented Mar 8, 2015

Likely fixed for issue #1882 -- the change is needed in any event.

@otoolep
Copy link
Contributor Author

otoolep commented Mar 9, 2015

Rebased and conflicts resolved.

@otoolep otoolep added review and removed 2 - Working labels Mar 9, 2015
@pauldix
Copy link
Member

pauldix commented Mar 9, 2015

looks good. Guess it's hard to write a test for this kind of thing. 🚢

@dgnorton
Copy link
Contributor

dgnorton commented Mar 9, 2015

I think we need locking in the apply* functions while modifying the metastore.

@dgnorton
Copy link
Contributor

dgnorton commented Mar 9, 2015

Nevermind. I forgot there was locking in processor before each apply function is called. LGTM. :shipit:

@otoolep
Copy link
Contributor Author

otoolep commented Mar 9, 2015

Thanks for the review @pauldix, @dgnorton -- merging now.

otoolep added a commit that referenced this pull request Mar 9, 2015
@otoolep
Merge pull request #1883 from influxdb/retention_crash
f6d1a00 
RLock Server when checking retention policies
@otoolep otoolep merged commit f6d1a00 into master Mar 9, 2015
@otoolep otoolep removed the review label Mar 9, 2015
@otoolep otoolep deleted the retention_crash branch March 9, 2015 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otoolep @pauldix @dgnorton