Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support control of Raft debug logging #1875

Merged
merged 3 commits into from
Mar 9, 2015
Merged

Support control of Raft debug logging #1875

merged 3 commits into from
Mar 9, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Mar 6, 2015

No description provided.

@otoolep otoolep force-pushed the raft_log_trace branch 2 times, most recently from 44cab9e to b4d9396 Compare March 6, 2015 19:37
@otoolep
Copy link
Contributor Author

otoolep commented Mar 6, 2015

@pauldix

@otoolep otoolep added review and removed 2 - Working labels Mar 6, 2015
@@ -98,6 +98,7 @@ type Config struct {
Logging struct {
File string `toml:"file"`
WriteTraceEnabled bool `toml:"write-tracing"`
RaftTraceEnabled bool `toml:"raft-tracing"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just remove Enabled from these. Otherwise everything in this struct is going to have that after it. Besides, this looks fine:

if log.WriteTrace {
  // do stuff
}

@otoolep
Copy link
Contributor Author

otoolep commented Mar 8, 2015

Updated.

@pauldix
Copy link
Member

pauldix commented Mar 9, 2015

:shipit:

otoolep added a commit that referenced this pull request Mar 9, 2015
Support control of Raft debug logging
@otoolep otoolep merged commit c714f14 into master Mar 9, 2015
@otoolep otoolep removed the review label Mar 9, 2015
@otoolep otoolep deleted the raft_log_trace branch March 9, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants