fix #1180: race in startStateLoop #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgnorton
force-pushed
the
fix-1180
branch
2 times, most recently
from
e49d1f9 to
3415a7e
Compare
| defer l.wg.Done() | ||
|
|
||
| l.Logger.Printf("log state change: %s => %s", l.state, state) |
There was a problem hiding this comment.
With these two lines in place, you should remove them from the for loop, right?
There was a problem hiding this comment.
It still needs them so it can log the transition each time through the loop.
|
same question as philip above, otherwise looks good to me. |
dgnorton
added a commit
that referenced
this pull request
Mar 6, 2015
fix #1180: race in startStateLoop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.