Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(handler): allow CORS in v2 compatibility endpoints #18410

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 9, 2020

Closes #18391

Describe your proposed changes here.

See influxdata/influxdb-client-js#199 to know more.

@sranka sranka added the 1.x label Jun 9, 2020
@sranka sranka marked this pull request as ready for review June 9, 2020 07:22
@sranka sranka requested a review from stuartcarnie June 9, 2020 07:22
@sranka
Copy link
Contributor Author

sranka commented Jun 9, 2020

With these changes, the browser example works fine (write, query, health) also when using a non-proxy influxdb URL (http://localhost:8086).

@sranka sranka linked an issue Jun 10, 2020 that may be closed by this pull request
@russorat russorat requested a review from dgnorton June 10, 2020 15:42
dgnorton
dgnorton previously approved these changes Jun 10, 2020
@sranka
Copy link
Contributor Author

sranka commented Jun 10, 2020

@dgnorton can you pls re-approve and merge, I only updated the CHANGELOG.md as requested in the issue's template ... but that dismissed your previous review. Updating CHANGELOG.md in pull requests comes with merging and approval problems for contributors with limited rights.

@sranka sranka requested a review from dgnorton June 10, 2020 18:09
@sranka sranka merged commit d46c6a8 into master-1.x Jun 26, 2020
@sranka sranka deleted the 18391/cors_v1 branch June 26, 2020 09:06
@sranka sranka mentioned this pull request Sep 24, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS in not allowed for /api/v2/query endpoint
4 participants