fix #1799: make scanner recognize regex #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the regex delimiter from single quotes to back ticks (`) and make the scanner recognize regex tokens. Single quotes are used for string literals. Using a unique delimiter for regular expression literals allows the scanner to recognize regular expression tokens, which is inline with the way the rest of the scanner / parser work.
|
LGTM, 🚢 |
dgnorton
added a commit
that referenced
this pull request
Mar 4, 2015
fix #1799: make scanner recognize regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the regex delimiter from single quotes to
/and makethe scanner recognize regex tokens.
Single quotes are used for string literals. Using a unique delimiter for
regular expression literals allows the scanner to recognize regular
expression tokens, which is inline with the way the rest of the
scanner / parser work.
TODO: