fix(httpd): Fixes key collisions when serializing /debug/vars #18004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
serveExpvar
so that it does not generate invalid JSON. Specifically, the improvement was made to prevent key collisions when serializing[]*monitor.Statistic
values.The algorithm works as such:
:<count>
In practice, key collisions for
hh_processor
were observed with Enterprise:This change will serialize these values as: