add --config-files option to fpm command

[kylezh]

This is to avoid overwritten of config file when update package.

Signed-off-by: Kai Zhang zhangk1985@gmail.com

[otoolep]

What exactly does this change solve? What can happen?

[kylezh]

@otoolep you could find something here: jordansissel/fpm#463

Let met show an example in rpm.

In short, if I update a package under Centos by rpm -U influxdb-xxx.rpm, the config file which was in /etc/opt/influxdb/influxdb.conf will be replaced by the config file in the new rpm. It means modifications on old config file will be lost, which is not expected.

If we add --config-files option to fpm command, the old config file will be remained after the package is updated.

A more sophisticated rule could be find here http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html

However, I'm not quite familiar with deb package. But I think it should have a similar effect.

[otoolep]

OK, this is a real issue -- thanks for bringing that option to our attention I'll need to test it out.

@toddboom -- what do you think we want to happen? I think not overwriting installed config files is probably best.

[otoolep]

From reading the docs for "fpm" this option should be applied to a specific file, not a directory.

[otoolep]

To quote:

--config-files CONFIG_FILES Mark a file in the package as being a config file.

[kylezh]

@otoolep Where did you find the document?

I found a different version from here

--config-files CONFIG_FILES   Mark a file in the package as being a config file. This uses 'conffiles' in debs and %config in rpm. If you have multiple files to mark as configuration files, specify this flag multiple times.  If argument is directory all files inside it will be recursively marked as config files.

[otoolep]

~/coding/bleve-test/main $ fpm -help | grep config
    --config-files CONFIG_FILES   Mark a file in the package as being a config file. This uses 'conffiles' in debs and %config in rpm. If you have multiple files to mark as configuration files, specify this flag multiple times.  If argument is directory all files inside it will be recursively marked as config files.
    --deb-config SCRIPTPATH       (deb only) Add SCRIPTPATH as debconf config file.
    --deb-default FILEPATH        (deb only) Add FILEPATH as /etc/default configuration
    --python-install-lib LIB_PATH (python only) The path to where python libs should be installed to (default depends on your python installation). Want to find out what your target platform is using? Run this: python -c 'from distutils.sysconfig import get_python_lib; print get_python_lib()'

[kylezh]

The last sentence of the line shows If argument is directory all files inside it will be recursively marked as config files.. So I think the argument can be a directory. Right?

[otoolep]

OK, yeah, I see that now. Seems like this should work. I'll test it, and if it looks good, we'll merge -- thanks @kylezh

[kylezh]

That's greate! Thanks!

[otoolep]

OK, I tested this with debian package creation, and it works well. Thanks again @kylezh .