Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make show series return IDs and work with limit and offset. #1771

Merged
merged 2 commits into from
Feb 27, 2015

Conversation

pauldix
Copy link
Member

@pauldix pauldix commented Feb 27, 2015

No description provided.

@pauldix pauldix force-pushed the show-series-updates branch 2 times, most recently from 2cd8f2c to 4b3c650 Compare February 27, 2015 02:21

// Append the row to the result.
result.Series = append(result.Series, r)
}

if stmt.Limit > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be if stmt.Limt > 0 || stmt.Offset > 0 {?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes

@dgnorton
Copy link
Contributor

Couple inline comments. Ohterwise, lgtm :shipit:

@pauldix pauldix force-pushed the show-series-updates branch from 099d044 to a26f11f Compare February 27, 2015 06:09
pauldix added a commit that referenced this pull request Feb 27, 2015
Make show series return IDs and work with limit and offset.
@pauldix pauldix merged commit 487cd2a into master Feb 27, 2015
@pauldix pauldix deleted the show-series-updates branch February 27, 2015 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants