Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop series failing Issue #1761 #1767

Merged
merged 8 commits into from
Feb 27, 2015
Merged

Drop series failing Issue #1761 #1767

merged 8 commits into from
Feb 27, 2015

Conversation

corylanou
Copy link
Contributor

Fixes #1761

Drop series was failing when multiple shards exists from writing data across time boundaries for a retention policy.

Also uncovered that SHOW SERIES could return blank rows for measurements where all measurement series had been deleted. This has been fixed as well.

Added some better error messages with context to assist in future debugging.

Enhanced a shell script test that allowed this bug to also be reproduced by hand.

@corylanou corylanou force-pushed the drop-series-failing-1761 branch from e03886a to 2a9306f Compare February 27, 2015 00:10
@pauldix
Copy link
Member

pauldix commented Feb 27, 2015

LGTM, :shipit:

corylanou added a commit that referenced this pull request Feb 27, 2015
@corylanou corylanou merged commit 7cd20b5 into master Feb 27, 2015
@corylanou corylanou deleted the drop-series-failing-1761 branch February 27, 2015 01:08
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
* Adjust proportions

* Ensure contents don't touch the bottom of the viewport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have to drop a series twice for it to work
2 participants