Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple change so "SHOW TAG VALUES" is as expected #1689

Merged
merged 1 commit into from
Feb 24, 2015
Merged

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Feb 23, 2015

This change only covers the case where a values for a single tag key is
requested, since there is a question whether anything else should be
supported.

@otoolep
Copy link
Contributor Author

otoolep commented Feb 23, 2015

Fixes basic case for #1688

@otoolep
Copy link
Contributor Author

otoolep commented Feb 23, 2015

@pauldix @dgnorton

@otoolep
Copy link
Contributor Author

otoolep commented Feb 23, 2015

Review again, updated as per spec.

@otoolep otoolep force-pushed the show_tag_values branch 2 times, most recently from fac092c to fcb982a Compare February 24, 2015 01:05
@otoolep
Copy link
Contributor Author

otoolep commented Feb 24, 2015

This passes locally, trying to see what is up with Travis.

This change tightens up the type used for "Series" so the pre-existing
sort method can be used.
@otoolep
Copy link
Contributor Author

otoolep commented Feb 24, 2015

Finally, green build after I fixed up the types. No more 'go vet' issues.

pauldix added a commit that referenced this pull request Feb 24, 2015
Simple change so "SHOW TAG VALUES" is as expected
@pauldix pauldix merged commit 0d05ca3 into master Feb 24, 2015
@pauldix pauldix deleted the show_tag_values branch February 24, 2015 04:47
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
…oup()` (#1689)

update other modules that used old syntax as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants