fix(tsdb): incorrect error type in type switch #16411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@e-dard can you add 1.x label? |
e-dard
reviewed
Feb 12, 2020
| // Maybe we can just change it to be consistent if we change it also in all | ||
| // the places that construct it. | ||
| case *PartialWriteError: | ||
| case PartialWriteError: |
There was a problem hiding this comment.
Is there a unit test somewhere that can cover this?
There was a problem hiding this comment.
Seems no yet, for the error type. I will add a test case in index/inmem since this error is only populated from inmem index
With 0ccea81, it should be checking `PartialWriteError` instead of `*PartialWriteError`
foobar
force-pushed
the
fix-error-type
branch
from
3b0c975 to
d180397
Compare
|
@e-dard can you take a look at the updated version? |
e-dard
approved these changes
Feb 25, 2020
dgnorton
approved these changes
Feb 26, 2020
|
@foobar thanks. Would you mind cherry-picking this to the 1.8 branch also? |
|
Issue for forward porting this fix to 1.8: #17020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 0ccea81, it should be checking
PartialWriteErrorinstead of*PartialWriteError