Wire up DROP CONTINUOUS QUERY #1631
Conversation
| } | ||
| } | ||
|
|
||
| if cqIndex == -1 { |
There was a problem hiding this comment.
So actually, this could happen, even if everything is OK. If two "drop CQ" commands for the same CQ hit the cluster at different nodes at the same time, one will win, but the other may still have gotten through before the first deletion finished. So if this happens, simply return nil here. In other words, make this operation idempotent.
There was a problem hiding this comment.
I guess this could happen in lots of other places too, actually, so maybe it doesn't matter. Worse thing that happens is that the user gets "does not exist" back, which is what he wanted anyway. So doesn't matter.
|
Looks good, +1. Ignore my comment about the race issue, it doesn't really matter. |
toddboom
force-pushed
the
drop-continuous-query
branch
from
b1a5d33 to
8842110
Compare
Wire up DROP CONTINUOUS QUERY
|
The test looks good to me, but I have not actually been able to get this to work against a running InfluxDB server, see #2141 |
feat(ui/DataLoaders): Streaming/Listening step
Format is:
DROP CONTINUOUS QUERY foo ON barWhere foo is the name of the query and bar is the database. It should only delete the continuous query. Shouldn't have to drop any data, just remove the CQ