reuse Write and ReadOptions

[jmhodges]

levigo.WriteOptions and levigo.ReadOptions are immutable config options that you can make once for each config that you need, and reuse. There's a few places in LevelDbDatastore that needlessly create them on every method call.

[jmhodges]

Oh man, in case someone comes along and sees my poor (cold induced) word choice: s/immutable/unmodified by leveldb/

Nice job getting this in so fast.

[pauldix]

No problem, thanks for looking at our code and telling us how to make it
better! I assume it's safe to share those options across goroutines?

On Tue, Nov 5, 2013 at 4:21 PM, Jeff Hodges notifications@github.comwrote:

Oh man, in case someone comes along and sees my poor (cold induced) word
choice: s/immutable/unmodified by leveldb/

Nice job getting this in so fast.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-27813472
.

[jmhodges]

It is (unless you modify them yourself, of course)!