Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in transform iterator on division #6419

Merged
merged 1 commit into from
Apr 20, 2016
Merged

fix panic in transform iterator on division #6419

merged 1 commit into from
Apr 20, 2016

Conversation

thbourlove
Copy link
Contributor

@thbourlove thbourlove commented Apr 19, 2016

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

if left point is nil in division expr, the influxd server would panic. Now check left point before use it.

@e-dard
Copy link
Contributor

e-dard commented Apr 19, 2016

LGTM 👍

@jwilder
Copy link
Contributor

jwilder commented Apr 19, 2016

@jsternberg

@jwilder jwilder added this to the 0.13.0 milestone Apr 19, 2016
@jsternberg
Copy link
Contributor

LGTM 👍

@thbourlove can you rebase and I'll try to merge it before another conflict happens?

if left point is nil in division expr, the influxd server would panic. Now check left point before use it.
@thbourlove
Copy link
Contributor Author

ping @jsternberg

@jsternberg jsternberg merged commit e3275f2 into influxdata:master Apr 20, 2016
timhallinflux added a commit that referenced this pull request Dec 20, 2016
v0.13.0 -- added #6419: Fix panic in transform iterator on division. @thbourlove
v0.12.2 -- #6419 was backported to 0.12.2 as well as PR #6431: Fix panic in transform iterator on division. @thbourlove.  Added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants