Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform further system test of shard precreation #3029

Closed
otoolep opened this issue Jun 17, 2015 · 4 comments
Closed

Perform further system test of shard precreation #3029

otoolep opened this issue Jun 17, 2015 · 4 comments
Assignees
Milestone

Comments

@otoolep
Copy link
Contributor

otoolep commented Jun 17, 2015

I had test data write some data to the past, and saw the output below from shard precreation. I need to confirm if it is correct. The logging also needs more details, such as start and end times for the created shard groups and shards.

2015/06/17 11:49:08 pre-creating successive shard group for group 1, database db, policy rp
2015/06/17 11:49:09 new shard group 3 successfully created
2015/06/17 11:49:09 pre-creating successive shard group for group 2, database db, policy rp
2015/06/17 11:49:10 new shard group 4 successfully created
2015/06/17 11:59:10 pre-creating successive shard group for group 1, database db, policy rp
2015/06/17 11:59:10 new shard group 3 successfully created
2015/06/17 11:59:10 pre-creating successive shard group for group 2, database db, policy rp
2015/06/17 11:59:10 new shard group 4 successfully created
2015/06/17 11:59:10 pre-creating successive shard group for group 3, database db, policy rp
2015/06/17 11:59:10 new shard group 2 successfully created
@otoolep otoolep added this to the 0.9.1 milestone Jun 17, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Jun 17, 2015

I suspect much of the output is from CreateShardGroupsIfNotExist which doesn't actually create the groups if they already exist. The log message may need to be updated to reflect this reality.

@neonstalwart
Copy link
Contributor

yes please, some more insight here would be helpful

@otoolep
Copy link
Contributor Author

otoolep commented Jun 17, 2015

Confirmed, logging gives the impressions that shard groups are constantly being created, which is not the case.

@otoolep
Copy link
Contributor Author

otoolep commented Jun 17, 2015

Shard creation logging is now sensible.

@otoolep otoolep closed this as completed Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants