-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compact() should not update queue lengths if a compaction has locked the files to be compacted [Port to master] #22141
Labels
Comments
davidby-influx
added
area/stats
area/storage
area/2.x
OSS 2.0 related issues and PRs
team/edge
labels
Aug 9, 2021
davidby-influx
added a commit
that referenced
this issue
Aug 17, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141
4 tasks
davidby-influx
added a commit
that referenced
this issue
Aug 17, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141
davidby-influx
added a commit
that referenced
this issue
Aug 17, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141
davidby-influx
added a commit
that referenced
this issue
Aug 17, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141
davidby-influx
added a commit
that referenced
this issue
Aug 17, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141 (cherry picked from commit 9923d2e) closes #22142
4 tasks
davidby-influx
added a commit
that referenced
this issue
Aug 18, 2021
When the compaction planner runs, if it cannot acquire a lock on the files it plans to compact, it returns a nil list of compaction groups. This, in turn, sets the engine statistics for compactions queues to zero, which is incorrect. Instead, use the length of pending files which would have been returned. closes #22138 (cherry picked from commit 7d3efe1) closes #22141 (cherry picked from commit 9923d2e) closes #22142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Port #22138 to the master branch
The text was updated successfully, but these errors were encountered: