Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not panic on cleaning up failed iterators [port to 1.9] #21667

Closed
davidby-influx opened this issue Jun 11, 2021 · 0 comments · Fixed by #21697
Closed

Do not panic on cleaning up failed iterators [port to 1.9] #21667

davidby-influx opened this issue Jun 11, 2021 · 0 comments · Fixed by #21697
Assignees
@davidby-influx
Labels
1.x area/queries kind/bug panic team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #21666 commits to 1.9
@davidby-influx davidby-influx self-assigned this Jun 11, 2021
@davidby-influx davidby-influx mentioned this issue Jun 15, 2021
Merged
4 tasks
@davidby-influx davidby-influx linked a pull request Jun 15, 2021 that will close this issue
fix: do not panic on cleaning up failed iterators (#21666) #21697
Merged
4 tasks
davidby-influx added a commit that referenced this issue Jun 15, 2021
@davidby-influx
fix: do not panic on cleaning up failed iterators (#21666) (#21697)
ae851d9 
We have seen occasional panics in Iterators.Close()
when cleaning up after failed iterator creation.
This commit checks for nil on any iterator to be
closed, and now returns any errors generated by
that Close().

Closes #19579
Closes #19476

(cherry picked from commit acc4105)

Closes #21667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/queries kind/bug panic team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not panic on cleaning up failed iterators (#21666) influxdata/influxdb
1 participant
@davidby-influx