Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anti-Entropy loops endlessly with empty shard #21273

Closed
davidby-influx opened this issue Apr 21, 2021 · 0 comments · Fixed by #21275
Closed

Anti-Entropy loops endlessly with empty shard #21273

davidby-influx opened this issue Apr 21, 2021 · 0 comments · Fixed by #21275
Assignees
@davidby-influx
Labels
1.x kind/bug needs-backport/1.8 team/edge

Comments

@davidby-influx
Copy link
Contributor

This is a fix for an issue only seen in the Enterprise version of Influx.

In this change, the FileStore.LastModification() for an empty directory with no shard files is set to the modification time of the directory itself, instead of the Unix epoch. This is part of the changes necessary to prevent a bug in the anti-entropy service. The change does not affect any directory which has shard files in it.
@davidby-influx davidby-influx self-assigned this Apr 21, 2021
davidby-influx added a commit that referenced this issue Apr 21, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard
bda3d28 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modificaiton time
of that directory, instead of to the Unix epoch.

Fixes: #21273
@davidby-influx davidby-influx mentioned this issue Apr 21, 2021
Merged
3 tasks
@davidby-influx davidby-influx linked a pull request Apr 21, 2021 that will close this issue
fix: Anti-Entropy loops endlessly with empty shard #21275
Merged
3 tasks
davidby-influx added a commit that referenced this issue Apr 23, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard (#21275)
7f300dc 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modification time
of that directory, instead of to the Unix epoch.

Fixes: #21273
This was referenced Apr 23, 2021
Closed
Closed
Closed
davidby-influx added a commit that referenced this issue Apr 23, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard (#21275)
cf0a28b 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modification time
of that directory, instead of to the Unix epoch.

Fixes: #21273
(cherry picked from commit 7f300dc)
@davidby-influx davidby-influx mentioned this issue Apr 23, 2021
Merged
4 tasks
davidby-influx added a commit that referenced this issue Apr 26, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard (#21275) (#21290)
e234aa7 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modification time
of that directory, instead of to the Unix epoch.

Fixes: #21273
(cherry picked from commit 7f300dc)
davidby-influx added a commit that referenced this issue Apr 27, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard (#21275)
58742a5 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modification time
of that directory, instead of to the Unix epoch.

Fixes: #21273
(cherry picked from commit 7f300dc)
@davidby-influx davidby-influx mentioned this issue Apr 27, 2021
Merged
4 tasks
davidby-influx added a commit that referenced this issue Apr 28, 2021
@davidby-influx
fix: Anti-Entropy loops endlessly with empty shard (#21310)
29b8887 
The anti-entropy service will loop trying to copy an empty shard to a
data node missing that shard.  This fix is one of two changes that
correctly create an empty shard on a new node. This fix will set the
LastModified date of an empty shard directory to the modification time
of that directory, instead of to the Unix epoch.

Fixes: #21273
(cherry picked from commit 7f300dc)

fixes #21287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x kind/bug needs-backport/1.8 team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Anti-Entropy loops endlessly with empty shard influxdata/influxdb
1 participant
@davidby-influx