Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit writes with precision, but without an explicit timestamp #2124

Closed
otoolep opened this issue Mar 31, 2015 · 3 comments
Closed

Prohibit writes with precision, but without an explicit timestamp #2124

otoolep opened this issue Mar 31, 2015 · 3 comments
Labels
area/writes breaking change RFC

Comments

@otoolep
Copy link
Contributor

otoolep commented Mar 31, 2015

This should be blocked in 0.9.
@gst
Copy link

gst commented Mar 31, 2015

Probably useful to give the link to the discussion that lead to this : https://groups.google.com/forum/#!topic/influxdb/yWpv_WJ6-uU

gst pushed a commit to savoirfairelinux/influxdb-python that referenced this issue Mar 31, 2015
Test fix: precision should only be used with timestamp provided
aee6d93 
for refs see:

influxdata/influxdb#2124
https://groups.google.com/forum/#!topic/influxdb/yWpv_WJ6-uU
@gst gst mentioned this issue Mar 31, 2015
Merged
@beckettsean beckettsean added the RFC label May 5, 2015
@beckettsean beckettsean added this to the Next Point Release milestone May 5, 2015
@beckettsean beckettsean modified the milestones: Next Point Release, Longer term Aug 6, 2015
@beckettsean beckettsean removed this from the Longer term milestone Sep 17, 2015
@jsternberg
Copy link
Contributor

This never got done before the 1.0 freeze and I think this is a breaking change so I'm going to make a PR to add this to the v2 TODO list so we can remember this exists and close out this issue.

jsternberg added a commit that referenced this issue Aug 12, 2016
@jsternberg
Add issue #2124 to the TODO list for v2
9757efd 
It would be a breaking change to v1, but it is something we likely want
to consider when we are working on v2.
jsternberg added a commit that referenced this issue Aug 15, 2016
@jsternberg
Merge pull request #7147 from influxdata/js-2124-prohibit-writes-with…
b84dbfd 
…-precision-todo

Add issue #2124 to the TODO list for v2
@jsternberg
Copy link
Contributor

jsternberg commented Aug 15, 2016 •
edited
Loading

Added this to the TODO list for v2. Might become part of the v2 line protocol too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/writes breaking change RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gst @otoolep @jsternberg @beckettsean