Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 API missing X-version and X-Build Headers #20224

Closed
danxmoran opened this issue Dec 1, 2020 · 1 comment · Fixed by #22535
Closed

2.0 API missing X-version and X-Build Headers #20224

danxmoran opened this issue Dec 1, 2020 · 1 comment · Fixed by #22535
Labels
area/api area/2.x OSS 2.0 related issues and PRs

Comments

@danxmoran
Copy link
Contributor

Per previous guidance: #6756

To aid with troubleshooting, the X-Influxdb-Version and X-Influxdb-Build header should be set on all responses, even for unhandled routes.

Proposal from @timhallinflux:
Build = "OSS" (as opposed to "Cloud")
Version = release version
@danxmoran danxmoran added the area/2.x OSS 2.0 related issues and PRs label Dec 1, 2020
@russorat
Copy link
Contributor

this is a good idea IMO.

until then, we know the urls for our cloud clusters, so we could guess really well :)

This was referenced Jun 23, 2021
Merged
Closed
lesam added a commit to lesam/influxdb that referenced this issue Sep 21, 2021
@lesam
feat: set X-Influxdb-Version and X-Influxdb-Build headers
5e28c52 
Closes influxdata#20224
Also a forward port of influxdata#22038 since I saw the same test failing on 2.x
@lesam lesam mentioned this issue Sep 21, 2021
Merged
3 tasks
lesam added a commit to lesam/influxdb that referenced this issue Sep 21, 2021
@lesam
feat: set X-Influxdb-Version and X-Influxdb-Build headers
d65e67c 
Closes influxdata#20224
Also a forward port of influxdata#22038 since I saw the same test failing on 2.x
lesam added a commit that referenced this issue Sep 22, 2021
@lesam
feat: set X-Influxdb-Version and X-Influxdb-Build headers (#22535)
7dfd7de 
Closes #20224
Also a forward port of #22038 since I saw the same test failing on 2.x
lesam added a commit to lesam/influxdb that referenced this issue Sep 22, 2021
@lesam
feat: set X-Influxdb-Version and X-Influxdb-Build headers (influxdata…
eed2b04 
…#22535)

Closes influxdata#20224
Also a forward port of influxdata#22038 since I saw the same test failing on 2.x

(cherry picked from commit 7dfd7de)
lesam added a commit that referenced this issue Sep 22, 2021
@lesam
feat: set X-Influxdb-Version and X-Influxdb-Build headers (#22547)
d914557 
* feat: set X-Influxdb-Version and X-Influxdb-Build headers (#22535)

Closes #20224
Also a forward port of #22038 since I saw the same test failing on 2.x

(cherry picked from commit 7dfd7de)

* chore: run auto-formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set X-Influxdb-Version and X-Influxdb-Build headers lesam/influxdb
2 participants
@danxmoran @russorat