Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up COUNT DISTINCT aggregate #1891

Closed
pauldix opened this issue Mar 9, 2015 · 5 comments · Fixed by #2606
Closed

Wire up COUNT DISTINCT aggregate #1891

pauldix opened this issue Mar 9, 2015 · 5 comments · Fixed by #2606
Assignees
Milestone

Comments

@pauldix
Copy link
Member

pauldix commented Mar 9, 2015

From a syntax perspective it should look like this:

select count(distinct id) from events

The underlying implementation should use the DISTINCT Map function, but have a new reducer that combines the Map output and outputs a count.

@beckettsean beckettsean added this to the Next Point Release milestone Apr 20, 2015
@pauldix pauldix modified the milestones: 0.9.0, Next Point Release May 1, 2015
@pauldix
Copy link
Member Author

pauldix commented May 1, 2015

I should mention that the target could be either a field or a tag key. The implementation would be different depending on which type was passed in.

@toddboom toddboom modified the milestones: 0.9.0, 0.9.1 May 8, 2015
@corylanou
Copy link
Contributor

Is it more common to see this:

select COUNT(DISTINCT id) as count FROM events

@pauldix
Copy link
Member Author

pauldix commented May 12, 2015

@beckettsean derivative will actually use the nested syntax. We should just be validating it if they do a nesting that we don't support. See #1477

@pauldix pauldix changed the title Wire up count_distinct aggregate Wire up COUNT DISTINCT aggregate May 12, 2015
@pauldix
Copy link
Member Author

pauldix commented May 12, 2015

@corylanou agreed on your syntax, updated the issue to reflect that

@corylanou
Copy link
Contributor

This issue depends on #1815 being done first.

This was referenced May 19, 2015
@corylanou corylanou removed the review label May 20, 2015
mark-rushakoff pushed a commit that referenced this issue Jan 11, 2019
…tton

Add the ability to count down timer on listening for data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants