Update LIMIT and OFFSET to SLIMIT and SOFFSET and implement LIMIT and OFFSET

[pauldix]

LIMIT and OFFSET currently set the limit and the offset on the series that are returned. We need another layer of limiting, which is the number of data points in each of those series. Change the series limit and offset to SLIMIT and SOFFSET and update the current LIMIT and OFFSET to be limits and offsets for the points within each series.

This means that if you do a group by on a tag, you could potentially still get a ton of data back if the tag has a high cardinality.

[otoolep]

If this is all about paging through points in a series with a lot of data, and narrower time ranges are still not sufficient, seems like we do need it. No other command comes to mind.

[IngaFeick]

+1 on the functionality. It is very much needed indeed, but I would suggest to switch the names as I'd expect limiting on the database to be the more frequently used case (at least from the way that I use the database).

[IngaFeick]

Also I think using the LIMIT for the datapoint limit instead of the series is more compatible with sql tradition and previous versions of influxdb. Maybe use SLIMIT for a series limit instead?

[jnutzmann]

+1 for SLIMIT

I agree with Ynguibjoerg. To me, LIMIT should control the number of rows
returned. Also, I thought LIMIT was used this way in 0.8, so changing
meaning is confusing.
On Mar 2, 2015 4:44 AM, "Ynguibjoerg" notifications@github.com wrote:

Also I think using the LIMIT for the datapoint limit instead of the series
is more compatible with sql tradition and previous versions of influxdb.
Maybe use SLIMIT for a series limit instead?

—
Reply to this email directly or view it on GitHub
#1709 (comment).

[pauldix]

I think I'm sold on that. LIMIT and SLIMIT. Besides, it's easier to say "slimit" than "plimit", no?

[mre]

+1 Awesome!

[nemesifier]

👍 for LIMIT and SLIMIT