Merge pull request #2682 from influxdb/pr-checklist

Adding pr checklist
influxdata · May 28, 2015 · 6481054 · 6481054
2 parents 2507540 + 60207f4
commit 6481054
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Features
 - [1997](https://github.com/influxdb/influxdb/pull/1997): Update SELECT * to return tag values.
 - [2599](https://github.com/influxdb/influxdb/issues/2599): Add "epoch" URL param and return JSON time values as epoch instead of date strings.
+- [2682](https://github.com/influxdb/influxdb/issues/2682): Adding pr checklist to CONTRIBUTING.md
 
 ### Bugfixes
 - [2635](https://github.com/influxdb/influxdb/issues/2635): Fix querying against boolean field in WHERE clause.

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -54,6 +54,15 @@ To submit a pull request you should fork the InfluxDB repository, and make your
 
 There will usually be some back and forth as we finalize the change, but once that completes it may be merged.
 
+To assist in review for the PR, please add the following to your pull request comment:
+
+```md
+- [ ] CHANGELOG.md updated
+- [ ] Rebased/mergable
+- [ ] Tests pass
+- [ ] Sign [CLA](http://influxdb.com/community/cla.html) (if not already signed)
+```
+
 Use of third-party packages
 ------------
 A third-party package is defined as one that is not part of the standard Go distribution. Generally speaking we prefer to minimize our use of third-party packages, and avoid them unless absolutely necessarly. We'll often write a little bit of code rather than pull in a third-party package. Of course, we do use some third-party packages -- most importantly we use [BoltDB](https://github.com/boltdb/bolt) as the storage engine. So to maximise the chance your change will be accepted by us, use only the standard libaries, or the third-party packages we have decided to use.