Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redact the Authorization HTTP header from log #462

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 12, 2022

Proposed Changes

  1. Redacted Authorization HTTP header from log
  2. HTTP logs are logged into influxdb_client.client.http logger instead print to console by print

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #462 (c5c5bb7) into master (2839ddc) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   89.35%   89.45%   +0.10%     
==========================================
  Files          38       38              
  Lines        3260     3292      +32     
==========================================
+ Hits         2913     2945      +32     
  Misses        347      347              
Impacted Files Coverage Δ
influxdb_client/client/_base.py 97.84% <ø> (ø)
influxdb_client/_async/rest.py 78.22% <100.00%> (+0.17%) ⬆️
influxdb_client/_sync/rest.py 86.99% <100.00%> (+1.40%) ⬆️
influxdb_client/configuration.py 87.64% <100.00%> (-0.14%) ⬇️
influxdb_client/rest.py 91.83% <100.00%> (+5.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2839ddc...c5c5bb7. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 12, 2022 07:14
@bednar bednar requested a review from rhajek July 12, 2022 07:14
@bednar bednar merged commit 161e202 into master Jul 15, 2022
@bednar bednar deleted the authorization-header-redacted branch July 15, 2022 06:48
@bednar bednar added this to the 1.31.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants