-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add InfluxLoggingHandler to use the InfluxClient in python native logging #405
Conversation
@strom-und-spiele Thanks for the PR 👍 and I'm waiting to see what comes next. Please convert your PR to |
f099c63
to
db36282
Compare
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 93.26% 93.31% +0.05%
==========================================
Files 28 29 +1
Lines 2509 2544 +35
==========================================
+ Hits 2340 2374 +34
- Misses 169 170 +1
Continue to review full report at Codecov.
|
db36282
to
b284e6a
Compare
60d0829
to
cc8ce89
Compare
Using a |
It sounds reasonable, so feel free to add I'm a little worried about user confusion about this PR. Can you please mention in the PR title and documentation that it is about using client as a |
cc8ce89
to
cb637c2
Compare
d4df83e
to
f06f35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
a5b388a
to
9800c8a
Compare
9800c8a
to
a645cd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, everything looks good 👍
LGTM
Thanks reviewing. 🥇 |
Closes #364
Sample
Checklist / TODO
pytest tests
completes successfully/examples/
Possible improvement