Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serialization to DataFrame with nan values #378

Merged
merged 2 commits into from
Dec 7, 2021
Merged

fix: serialization to DataFrame with nan values #378

merged 2 commits into from
Dec 7, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Dec 7, 2021 •
edited
Loading

Closes #377

Proposed Changes

  1. Rollback regression caused by 500835f#diff-02179d31a524332a9b64b57d464f6a56c0725daf636a4a410a20ed2aa71a43e0
  2. Improve regex to match start field with null value

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review December 7, 2021 09:17
@bednar bednar requested a review from rhajek December 7, 2021 09:17
@bednar bednar mentioned this pull request Dec 7, 2021
Closed
@bednar bednar merged commit 0ebe302 into master Dec 7, 2021
@bednar bednar deleted the fix/serialization branch December 7, 2021 21:55
@bednar bednar added this to the 1.25.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Regression: invalid field format with NaN values
2 participants
@bednar @rhajek