fix: construct InfluxDBError without http response #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes an AttributeError while handling another error raised from a failed POST request. In detail, when a POST request fails during the connection establishment there is no http response, so when an InfluxDBError instance is constructed the response field is None . This leads to an AttributeError later when the response.data is accessed. The fix is a trivial None check in the InfluxDBError constructor so that a None response argument properly works.
I was able to reproduce it due to the expired ssl certificate error with the following traceback (Python 3.10/Windows server 2016):
Checklist
pytest tests
completes successfully