Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supports write_precision for write Pandas DataFrame #270

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 15, 2021

Closes #245

Proposed Changes

The dataframe_serializer.py supports write_precision.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek June 15, 2021 07:05
@bednar bednar marked this pull request as ready for review June 15, 2021 07:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #270 (51bd56c) into master (a2dbc0b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   92.56%   92.58%   +0.02%     
==========================================
  Files          27       27              
  Lines        2151     2158       +7     
==========================================
+ Hits         1991     1998       +7     
  Misses        160      160              
Impacted Files Coverage Δ
...fluxdb_client/client/write/dataframe_serializer.py 98.78% <100.00%> (+0.11%) ⬆️
influxdb_client/client/write_api.py 99.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dbc0b...51bd56c. Read the comment docs.

@bednar bednar merged commit e0e46cc into master Jun 16, 2021
@bednar bednar deleted the fix/dataframe-write-precision branch June 16, 2021 07:10
@bednar bednar added this to the 1.19.0 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support write_precision in _write_client.write when record is a Pandas dataframe
3 participants