Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add detail error message for not supported type of Point.field #241

Merged
merged 2 commits into from
May 5, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 30, 2021

Related to #239

Proposed Changes

Added detail error message for not supported type of Point.field

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 30, 2021 08:32
@bednar bednar requested a review from rhajek April 30, 2021 08:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #241 (6417394) into master (e26e7b0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6417394 differs from pull request most recent head 1d657e9. Consider uploading reports for the commit 1d657e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   91.87%   91.92%   +0.04%     
==========================================
  Files          25       25              
  Lines        2031     2031              
==========================================
+ Hits         1866     1867       +1     
+ Misses        165      164       -1     
Impacted Files Coverage Δ
influxdb_client/client/write/point.py 99.18% <100.00%> (+0.81%) ⬆️
influxdb_client/client/bucket_api.py 93.75% <0.00%> (ø)
influxdb_client/client/labels_api.py 96.87% <0.00%> (ø)
influxdb_client/client/organizations_api.py 84.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26e7b0...1d657e9. Read the comment docs.

@bednar bednar force-pushed the chore/unsupported_type_for_field branch from 6417394 to 1d657e9 Compare May 5, 2021 13:05
@bednar bednar added this to the 1.18.0 milestone May 5, 2021
@bednar bednar merged commit be6760d into master May 5, 2021
@bednar bednar deleted the chore/unsupported_type_for_field branch May 5, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants