#3: Fixed authorization API

influxdata · Aug 12, 2019 · bff1807 · bff1807
1 parent 03b29f2
commit bff1807
Showing 1 changed file with 8 additions and 13 deletions.
diff --git a/influxdb2_test/test_AuthorizationApi.py b/influxdb2_test/test_AuthorizationApi.py
@@ -31,8 +31,7 @@ def test_createAuthorization(self):
         self.assertEqual(authorization.user, self.user.name)
         self.assertEqual(authorization.org_id, self.organization.id)
         self.assertEqual(authorization.org, self.organization.name)
-        # todo
-        # self.assertEqual(authorization.status, "active")
+        self.assertEqual(authorization.status, "active")
         self.assertTrue(len(authorization.permissions) == 2)
         self.assertEqual(authorization.permissions[0].resource.type, "users")
         self.assertEqual(authorization.permissions[0].resource.org_id, self.organization.id)
@@ -51,17 +50,15 @@ def test_authorizationDescription(self):
         organization = self.my_organization
 
         resource = PermissionResource(org_id=organization.id, type="sources")
-        createSource = Permission(action="write", resource=resource)
+        create_source = Permission(action="write", resource=resource)
 
-        permissions = [createSource]
+        permissions = [create_source]
         authorization = Authorization(org_id=organization.id, permissions=permissions)
-        # todo
-        # authorization.setStatus(Authorization.StatusEnum.ACTIVE);
-        # authorization.setDescription("My description!");
+        authorization.status = "active"
+        authorization.description = "My description!"
         created = self.authorizations_client.create_authorization(authorization=authorization)
         self.assertIsNotNone(created)
-        # todo
-        # self.assertEqual(created.description, "My description")
+        self.assertEqual(created.description, "My description!")
 
     def test_createAuthorizationTask(self):
         resource = PermissionResource(org_id=self.organization.id, type="tasks")
@@ -144,7 +141,6 @@ def test_findAuthorizationsByOrgNotFound(self):
         authorizations_by_org_id = self.authorization_api().find_authorizations_by_org_id("ffffffffffffffff")
         self.assertEqual(len(authorizations_by_org_id), 0)
 
-    @pytest.mark.skip("todo inheritence codegen bug")
     def test_updateAuthorizationStatus(self):
         resource = PermissionResource(org_id=self.organization.id, type="users")
         read_user = Permission(action="read", resource=resource)
@@ -189,9 +185,8 @@ def test_clone_authorization(self):
         self.assertEqual(source.user, cloned.user)
         self.assertEqual(source.org_id, cloned.org_id)
         self.assertEqual(source.org, cloned.org)
-        ## todo
-        # self.assertEqual(source.status, cloned.status)
-        # self.assertEqual(source.description, cloned.description)
+        self.assertEqual(source.status, cloned.status)
+        self.assertEqual(source.description, cloned.description)
 
         self.assertTrue(len(cloned.permissions), 1)
         self.assertEqual(cloned.permissions[0].action, "read")