Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization tags which are not a string #81

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 23, 2021

Closes #80

Proposed Changes

Correct serialisation to LineProtocol for tags which are not a string.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek June 23, 2021 08:40
@bednar bednar marked this pull request as ready for review June 23, 2021 08:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #81 (3bcb197) into master (ae469fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     82.78%   82.78%           
  Complexity      375      375           
=========================================
  Files            23       23           
  Lines           889      889           
=========================================
  Hits            736      736           
  Misses          153      153           
Impacted Files Coverage Δ
src/InfluxDB2/Point.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae469fd...3bcb197. Read the comment docs.

@bednar bednar merged commit cf19d0f into master Jul 7, 2021
@bednar bednar deleted the fix/tag-types branch July 7, 2021 05:58
@bednar bednar added this to the 1.15.0 milestone Jul 7, 2021
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point::isNullOrEmptyString -- trim() expects parameter 1 to be string, array given
3 participants