-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allowed to change GuzzleHTTP timeout (#72) #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍.
There is a few requirements that should be satisfy before we accept the PR.
eca198b
to
a717a61
Compare
@alanaasmaa, do you want to continue with this PR? There aren't changes after your force push... |
Yes i would, I'm not very good with rebasing :D |
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 82.06% 82.08% +0.02%
Complexity 370 370
============================================
Files 22 22
Lines 853 854 +1
============================================
+ Hits 700 701 +1
Misses 153 153
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes #72
Proposed Changes
I made it possible to change guzzleHttp timeout.
Sadly i couldn't get tests to work so I can't run them. But I did manual testing, i'm only using Client and
createWriteApi
.Checklist
make test
completes successfully