Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allowed to change GuzzleHTTP timeout (#72) #74

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

alanaasmaa
Copy link
Contributor

@alanaasmaa alanaasmaa commented Mar 26, 2021

Closes #72

Proposed Changes

I made it possible to change guzzleHttp timeout.
Sadly i couldn't get tests to work so I can't run them. But I did manual testing, i'm only using Client and createWriteApi.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@alanaasmaa alanaasmaa marked this pull request as ready for review March 26, 2021 13:51
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍.

There is a few requirements that should be satisfy before we accept the PR.

src/InfluxDB2/DefaultApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/DefaultApi.php Outdated Show resolved Hide resolved
@bednar
Copy link
Contributor

bednar commented Mar 29, 2021

@alanaasmaa, do you want to continue with this PR? There aren't changes after your force push...

@alanaasmaa
Copy link
Contributor Author

alanaasmaa commented Mar 29, 2021

@alanaasmaa, do you want to continue with this PR? There aren't changes after your force push...

Yes i would, I'm not very good with rebasing :D
EDIT: Now there are those changes again, maybe some day i will learn how to use rebase correctly.

@alanaasmaa alanaasmaa reopened this Mar 29, 2021
@codecov-io
Copy link

codecov-io commented Mar 29, 2021

Codecov Report

Merging #74 (1de873f) into master (a717a61) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
+ Coverage     82.06%   82.08%   +0.02%     
  Complexity      370      370              
============================================
  Files            22       22              
  Lines           853      854       +1     
============================================
+ Hits            700      701       +1     
  Misses          153      153              
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/Client.php 93.54% <ø> (ø) 12.00 <0.00> (ø)
src/InfluxDB2/DefaultApi.php 84.37% <100.00%> (+0.24%) 17.00 <10.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a717a61...1de873f. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bednar bednar merged commit e4a5f54 into influxdata:master Mar 29, 2021
@bednar bednar added this to the 1.12.0 milestone Mar 29, 2021
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please support changing timeout.
3 participants