chore: move classes to their own file #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SMillerDev, Thanks for your PR 👍 We will take a look |
bednar
requested changes
Mar 4, 2021
SMillerDev
force-pushed
the
chore/cs/class_per_file
branch
from
889d91d to
a7db847
Compare
|
✅ |
bednar
approved these changes
Mar 5, 2021
peynman
pushed a commit
to peynman/influxdb-client-php
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since some IDEs have trouble dealing with multiple classes in a file, and it makes it easier for humans to find the class I suggest moving these classes to their own location.
Checklist
make testcompletes successfully