Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FluxRecord uses descriptive message for column that doesn't exists #65

Merged
merged 6 commits into from
Feb 8, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 5, 2021

Closes #64

Proposed Changes

  • FluxRecord uses descriptive message for column that doesn't exists
  • Added script to generate and deploy library doc:
    • make doc-generate - Generate documentation
    • make doc-publish - Publish documentation as GH-Pages

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

src/InfluxDB2/FluxRecord.php Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #65 (744aae7) into master (4c5f3d6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     81.95%   82.06%   +0.10%     
- Complexity      368      370       +2     
============================================
  Files            20       20              
  Lines           848      853       +5     
============================================
+ Hits            695      700       +5     
  Misses          153      153              
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/FluxRecord.php 100.00% <100.00%> (ø) 9.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5f3d6...b77109a. Read the comment docs.

@bednar bednar added this to the 1.11.0 milestone Feb 8, 2021
@bednar bednar merged commit 5306eaf into master Feb 8, 2021
@bednar bednar deleted the feat/flux-record-usage branch February 8, 2021 12:55
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDB2\FluxRecord->getValue() can spit out a PHP “Undefined Index” Notice
4 participants